Compile statically against the MSVC CRT #3363
Merged
+52
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
libcmt
branch
2 times, most recently
from
4b936aa
to
3392ae2
Compare
|
☔ The latest upstream changes (presumably #3395) made this pull request unmergeable. Please resolve the merge conflicts. |
This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static` to help Cargo be a bit more portable and not rely on the MSVC redistributable artifacts. Over time this may even let us converge on only releasing one build of Cargo and just pairing that with all Windows toolchains...
|
@bors: r+ |
|
📌 Commit db60e6c has been approved by |
|
⌛ Testing commit db60e6c with merge ff5ae77... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Tue, Dec 13, 2016 at 3:14 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.587>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3363 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HHkztXjFkxUQ-WRENbwErsReL9vks5rHyblgaJpZM4LDD-a>
.
|
bors
added a commit
that referenced
this pull request
Dec 14, 2016
Compile statically against the MSVC CRT This updates our AppVeyor builds to compile with `-Ctarget-feature=+crt-static` to help Cargo be a bit more portable and not rely on the MSVC redistributable artifacts. Over time this may even let us converge on only releasing one build of Cargo and just pairing that with all Windows toolchains...
|
☀️ Test successful - status-appveyor, status-travis |
Merged
|
Is there a way to specify a |
|
Not currently, no. It needs to be specified as part of |
|
I see. Thanks anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our AppVeyor builds to compile with
-Ctarget-feature=+crt-staticto help Cargo be a bit more portable and not rely on the MSVC redistributable
artifacts. Over time this may even let us converge on only releasing one build
of Cargo and just pairing that with all Windows toolchains...